Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" in the Rooms tab #5747

Closed
Tracked by #164
kittykat opened this issue Mar 4, 2022 · 2 comments
Closed
Tracked by #164

Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" in the Rooms tab #5747

kittykat opened this issue Mar 4, 2022 · 2 comments
Assignees
@gileluard
Labels
A-Room-List A-Spaces Spaces, groups, communities T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight X-Regression

Comments

@kittykat
Copy link
Contributor

kittykat commented Mar 4, 2022 •
edited
Loading

We want to come into sync with Android behaviour and make user flows logical

By having each room listed only once in the "Rooms" tab.

So if a suggested room has been joined by a user, it should no longer appear under "Suggested rooms" and should only be visible under "Rooms".

Comparison of same view on Android and iOS

iOS showing an extra suggested room:
ima_3642725

Android showing only rooms that user is not a member of under "Suggested":
Screenshot_20220304-113825
@kittykat kittykat mentioned this issue Mar 4, 2022
Closed
20 tasks
@kittykat kittykat changed the title iOS: Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" at the bottom of the "Rooms" tab Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" at the bottom of the "Rooms" tab Mar 4, 2022
@kittykat kittykat changed the title Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" at the bottom of the "Rooms" tab Do not repeat suggested rooms which have been joined in the list of "Suggested rooms" in the Rooms tab Mar 4, 2022
@kittykat kittykat transferred this issue from element-hq/element-meta Mar 4, 2022
@kittykat kittykat added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Spaces Spaces, groups, communities A-Room-List Team: Delight labels Mar 4, 2022
@gileluard
Copy link
Contributor

Seems to be a duplicate of #5276. Just need to check if the bug is also fixed for the rooms screen.

@gileluard
Copy link
Contributor

duplicate of #5276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Room-List A-Spaces Spaces, groups, communities T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittykat @gileluard