Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Token Authenticated Registration (MSC3231) #6507

Open
sailoona opened this issue Aug 1, 2022 · 10 comments
Open

Add support for Token Authenticated Registration (MSC3231) #6507

sailoona opened this issue Aug 1, 2022 · 10 comments
Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@sailoona
Copy link

sailoona commented Aug 1, 2022

server matrix-synapse-1.61.1

@sailoona sailoona changed the title unrecognized request (m_unrecognized) error for token registration unrecognized request (m_unrecognized) error for token based user registration Aug 1, 2022
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Info This issue is blocked pending further information from the reporter labels Aug 2, 2022
@pixlwave
Copy link
Member

pixlwave commented Aug 2, 2022

Hi @sailoona just to confirm, are you attempting Token Authenticated Registration ala MSC3231 or is this some other flow that you're experiencing an issue with?

Please could you add more information to the ticket, for example:

  • Element Version
  • iOS Version
  • Device
  • Homeserver
  • Steps to reproduce the error

Thanks very much

@sailoona
Copy link
Author

sailoona commented Aug 2, 2022

Token Authenticated Registration ala MSC3231
Matrix-synapse 1.61.1
homeserver.yaml config:
enable_registration: true
registration_requires_token: true

iOS: 15.6
Element Version: 1.8.24
Device: iPhone Xr

Steps to reproduce the error:
Click button Create Account ->
Select Friends and Family ->
Edit server to chat.loonol.com ->
Click Button Register ->
Creat account: user and password ->
Click button Sign up ->
Red Error: Unrecognized request (M_UNRECOGNIZED)

Thanks

@pixlwave pixlwave changed the title unrecognized request (m_unrecognized) error for token based user registration Add support for Token Authenticated Registration (MSC3231) Aug 3, 2022
@pixlwave pixlwave removed the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 3, 2022
@pixlwave pixlwave added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Authentication and removed X-Needs-Info This issue is blocked pending further information from the reporter labels Aug 3, 2022
@pixlwave
Copy link
Member

pixlwave commented Aug 3, 2022

Thanks, I've updated the issue accordingly 👍

@bijoni
Copy link

bijoni commented Jul 5, 2023

Synapse Version: [v1.86.0]
homeserver.yaml config:
enable_registration: true
registration_requires_token: true

After changing the homeserver, and then press the register button in Element app, a webpage shown No such Resource is displayed.

Please follow up this. Thank you!

@cloudaxes
Copy link

+1 to this issue. I am running a homeserver (matrix-synapse-py3 v1.90.0+jammy1) with registration enabled only with registration tokens. The up-to-date version of Element from the iOS app store (v1.11.0) has the same behavior that @bijoni describes: clicking the register button in Element leads to a page that says "No such resource". I'm able to register new users with registration tokens from the Mac Element app and the Linux Element app.

The server log from the iOS app failing to register is as follow:

2023-08-28 13:12:42,450 - synapse.access.http.8008 - 465 - INFO - GET-462 - 1.244.12.121 - 8008 - {None} Processed request: 0.000sec/-0.000sec (0.002sec, 0.000sec) (0.000sec/0.000sec/0) 145B 404 "GET /_matrix/static/client/register/ HTTP/1.1" "Mozilla/5.0" [0 dbevts]

I am just hypothesizing, but it looks like this is a endpoint was removed from Synapse couple months ago: matrix-org/synapse#15405. I think it's only used by the iOS Element app when registering a new user using a registration token, which is why this regression has gone unnoticed for a few months.

@moltenbit
Copy link

+1
Registration with token not working on iOS and Android.

@Dan-Tinsman
Copy link

Any resolutions to this? Experiencing this issue now. @bijoni @cloudaxes @moltenbit did any of you ever come up with a solution?

@cloudaxes
Copy link

@Dan-Tinsman, yea, I stopped using registration tokens.

@robbystk
Copy link

The flagship client having registration via tokens is a make-or-break feature for me and my family to be able to use Matrix. I am going to take a stab at implementing this but it will be my first time writing Swift or Objective C. If anyone would be able to point me towards relevant parts of the codebase I'd appreciate it.

@pixlwave
Copy link
Member

The flagship client having registration via tokens is a make-or-break feature for me and my family to be able to use Matrix. I am going to take a stab at implementing this but it will be my first time writing Swift or Objective C. If anyone would be able to point me towards relevant parts of the codebase I'd appreciate it.

@robbystk Thanks for this offer however I'm afraid that the team is now focussed on Element X iOS and so unless it is a high severity bug fix, or something to aid adoption/migration of Element X, we don't have the time to dedicate to the old app for adding or reviewing new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

7 participants