Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group DM] send a new message in an existing DM invite again one of left member #6691

Closed
giomfo opened this issue Sep 8, 2022 · 3 comments · Fixed by #6695
Closed

[Group DM] send a new message in an existing DM invite again one of left member #6691

giomfo opened this issue Sep 8, 2022 · 3 comments · Fixed by #6695
Assignees
@giomfo
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-PS-Request

Comments

@giomfo
Copy link
Member

giomfo commented Sep 8, 2022 •
edited
Loading

I updated the title and the description of this issue after investigation

Steps to reproduce

  1. Create a DM with userA
  2. Invite userB and userC in the resulting DM
  3. accept the 3 invitation
  4. userA and userC leave the room
  5. Send a new message in the DM -> the userA is invited again before sending the new message

Outcome

This is related to #5864
During the implementation of the feature "create DM only on first message", we delivered a second feature "if I have a DM with the selected contact that they left -> I want to open it and invite again the contact when I send a new message (instead of creating a new one)" - details

We should limit this auto invite on new message only on actual 1:1 DM

Your phone model

No response

Operating system version

No response

Application version

v1.9.3 RC

Homeserver

No response

Will you send logs?

No
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Sponsored Z-PS-Request labels Sep 8, 2022
@giomfo giomfo self-assigned this Sep 8, 2022
@giomfo giomfo changed the title [DM] send a new message in an existing DM invite again left members [Group DM] send a new message in an existing DM invite again one of left member Sep 8, 2022
@yostyle yostyle added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Sep 8, 2022
@giomfo giomfo mentioned this issue Sep 8, 2022
Merged
@toshanmugaraj
Copy link
Contributor

I think we need to disable the option to invite others in a DM.

@toshanmugaraj
Copy link
Contributor

If user A is member of many other DM groups , start chat opens unexpected rooms.

@pixlwave
Copy link
Member

@toshanmugaraj This issue has been closed by #6695.

If you're still seeing a problem could you create a new issue with steps to reproduce what you see please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giomfo giomfo

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-PS-Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the automatic invite on new message in a DM left by the direct user element-hq/element-ios
4 participants
@toshanmugaraj @yostyle @pixlwave @giomfo