Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the voice broadcast chunks at the notifications level #7208

Closed
giomfo opened this issue Dec 23, 2022 · 2 comments
Closed

Ignore the voice broadcast chunks at the notifications level #7208

giomfo opened this issue Dec 23, 2022 · 2 comments
Assignees
@yostyle
Labels
A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Dec 23, 2022

Your use case

What would you like to do?

During the notifications handling, we should ignore events related to the voice broadcast chunks

Why would you like to do it?

These events are not displayed in the room timeline, they should not be taken into account in the notifications count.
They are voice messages marked as voice broadcast chunks (they refer to a voice message state event)

There is no case where the user may want to be notified on these chunks, they are supposed to be invisible for them. That is why we can hardcode this mechanism client side without adding config in push rules

How would you like to achieve it?

We have to ignore them locally, because these events are encrypted, we could not ignore them server side

Have you considered any alternatives?

No response

Additional context

No response
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Voice-Broadcast labels Dec 23, 2022
@giomfo giomfo mentioned this issue Dec 23, 2022
Closed
@giomfo
Copy link
Member Author

giomfo commented Dec 23, 2022

related to element-hq/element-android#7845

@giomfo giomfo mentioned this issue Dec 23, 2022
Closed
@giomfo
Copy link
Member Author

giomfo commented Jan 17, 2023

fixed by #7230

@giomfo giomfo closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yostyle yostyle

Labels
A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yostyle @giomfo