-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't interpret underscores to mean 'italic' when used in the middle of a word. #1758
Comments
This is the behaviour of CommonMark Related element-hq/element-web#6434 element-hq/element-web#3534 |
I'm not sure this is really a duplicate of element-hq/element-web#4674 because that is specifically about URL's and this is a non-URL string. A fix for element-hq/element-web#4674 may or may not fix this case. |
Yup, you're right - it's actually a regression of element-hq/element-web#3428. It's probably very similar to element-hq/element-web#4674 but may not be. Will reopen. |
Right, so commonmark (I believe) does the 'right thing' for underscores in the middle of words. The problem is, it looks like commonmark doesn't consider # a word character: reference impl of commonmark showing the difference. Fwiw, GFM has exactly the same issue: #ircnet#hsnijmegen:irc.snt.utwente.nl element-hq/element-web#4674 (comment) outlines some possible solutions. I'd really like us to stick to an agreed markdown standard; could we address this with some creative pilling (by which I mean turning all aliases to pills and then mandating our own formatting?) |
What are/is pills/pilling? |
Description
When displaying a string that contains underscores, such as
#_ircnet_#hsnijmegen:irc.snt.utwente.nl
, the underscores are removed and the 'ircnet' fragment is shown in italic ("#ircnet#hsnijmegen:irc.snt.utwente.nl").It would be nicer to leave underscores be when encountered in the middle of a word, and only convert them to italic when they are added on word boundaries.
Version information
For the web app:
The text was updated successfully, but these errors were encountered: