Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge on suggested room preview in Spaces #181

Closed
2 tasks done
Tracked by #164
kittykat opened this issue Feb 24, 2022 · 5 comments
Closed
2 tasks done
Tracked by #164

Converge on suggested room preview in Spaces #181

kittykat opened this issue Feb 24, 2022 · 5 comments
Labels
A-Spaces Spaces, groups, communities App: Android App: iOS T-Task Tasks for the team like planning Team: Delight Z-IA Issues relating to information architecture Z-Labs

Comments

@kittykat
Copy link
Contributor

kittykat commented Feb 24, 2022

Android and iOS should have the same behaviour in terms of what to show when a suggested room for a Space is previewed from the Rooms tab.

  • iOS: Click on suggested rooms navigates to room preview
    ima_3a9ccab

  • Android: no preview shown, only toast
    Screenshot_20220304-115333

Tasks

  • Design input on what the correct behaviour should be
  • File an issue with designs for the change
@kittykat kittykat changed the title Suggested rooms -> standardise on room preview Converge on suggested room preview in Spaces Feb 24, 2022
@kittykat kittykat added A-Spaces Spaces, groups, communities Z-IA Issues relating to information architecture labels Feb 24, 2022
@kittykat kittykat self-assigned this Feb 24, 2022
@kittykat kittykat added the T-Task Tasks for the team like planning label Feb 25, 2022
@kittykat kittykat assigned niquewoodhouse and unassigned kittykat Mar 4, 2022
@niquewoodhouse
Copy link

@gileluard would you mind confirming please if this always happens for suggested rooms in Spaces?

iOS: Click on suggested rooms navigates to room preview

Because I remember you sharing something like this:
image

Thanks

@gileluard
Copy link

gileluard commented Mar 7, 2022

@niquewoodhouse you're right. The room preview is inconsistent over the app. From Space Explore Rooms the bottom sheet is opened while the room preview screen is opened from the other parts of the app.

@niquewoodhouse
Copy link

@gileluard can we make suggested rooms in Home act the same way as the room preview in Space Explore Rooms please? This would resolve this issue and if we wanted to make all previews the same/similar, it would be a different issue.

@gileluard
Copy link

@niquewoodhouse we definitively can!

@niquewoodhouse niquewoodhouse removed their assignment Mar 8, 2022
@kittykat
Copy link
Contributor Author

kittykat commented Mar 8, 2022

Issue for development filed at element-hq/element-ios#5771

@kittykat kittykat closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities App: Android App: iOS T-Task Tasks for the team like planning Team: Delight Z-IA Issues relating to information architecture Z-Labs
Projects
None yet
Development

No branches or pull requests

3 participants