Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge on displaying empty list items and numbered lists #189

Open
1 of 5 tasks
kittykat opened this issue Feb 28, 2022 · 2 comments
Open
1 of 5 tasks

Converge on displaying empty list items and numbered lists #189

kittykat opened this issue Feb 28, 2022 · 2 comments
Labels
A-Markdown A-Timeline App: Android App: iOS App: web O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@kittykat
Copy link
Contributor

kittykat commented Feb 28, 2022

@kittykat kittykat added App: web App: Android App: iOS A-Timeline A-Markdown S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 28, 2022
@kittykat kittykat self-assigned this Mar 7, 2022
@kittykat
Copy link
Contributor Author

kittykat commented Mar 21, 2022

Proposal for feedback:

  1. Lists with single items should be displayed literally, e.g.
  • 2021. Oct 12 should be displayed just like that rather than as 21. Oct 12 (Web), 1. Oct 12 (Android) or Oct 12 (iOS)
  • + foo should display literally, same as \+ foo
  • * foo should display literally, same as \* foo
  • - foo should display literally, same as \- foo
  1. \123. should display as "123." (in web, only 123\. seems to work right now)
  2. For *, - and +, e.g.:
  *
  * foo

should be shown as

  • foo

This is broken on Android, but working on iOS and web

  1. Changing between *, + and - should start a new unordered list with extra spacing between them as currently happens on web and iOS (broken on Android)
  2. If possible, the alignment for numbered list should be based off longest number so lists which are 100+ items long can still show the number correctly. This is useful if the user is, e.g., discussing a long numbered document with a group or in a DM. Ideally alignment should be per message with enough space for the longest number in the message.
  3. Blank line between list items should be considered to be the end of one list and start of the next list.

@dkasak
Copy link
Member

dkasak commented Mar 21, 2022

The above proposal sounds good to me and it encompasses all problematic cases which I can think of right now.

Note: When thinking about this, we need to take care to separate the case of a single message with a single list of N items and N messages each containing a single list with a single item. Both of these cases are currently rendered the same so they are sometimes mistaken as the same, but in the former case we have just a single list and in the latter cases we necessarily have N lists.

Changing between *, + and - should start a new unordered list with extra spacing between them as currently happens on web and iOS (broken on Android)

This should also be the behaviour if the list items use the same character but have empty lines interspersed.

So this is a compact list:

- a
- b
- c

And this is a loose list:

- a

- b

- c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Markdown A-Timeline App: Android App: iOS App: web O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants