-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room URLs are technically invalid #1903
Comments
Do we have everything we need to move forward with this? Are we free to move forward with implementing:
If there are outstanding questions about the @user form, can we still move forward with the #room links independently? |
technically @ is illegal there, but ruby doesn't choke on it. So i am inclined to go with it anyway, and if people complain further we can always provide a https://matrix.to/u/matthew:matrix.org style workaround or something horrid. |
Why not just |
Because then you need to configure your Web server to serve the file for subpaths and not only the root |
You're requiring a web server in the first place, of course it needs to be configured. It seems to solve several issues at once without any drawbacks. |
Riot-web doesn't require a Web server, you can just browse a filesystem copy using browsers file:// protocol |
Replying to the original issue @ara4n . Could you please cite the section that states that you can't have https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Syntax
The RFC actually defines a sane interpretation for using reserved characters unencoded:
Incidentally, I myself have opted to always escape |
You're technically not allowed to have unescaped # symbols in a URL fragment, like we do for URLs like https://riot.im/app/#/room/#matrix:matrix.org. This causes problems for some conservative URL parsers like Ruby's, who appear not to have heard of Postel's law O:-) - see general unhappiness over at https://meta.discourse.org/t/broken-links-blank-page-with-appearing-in-url/52640/11.
To fix this I suggest we switch matrix.to to using compact URLs by default - i.e. solving matrix-org/matrix.to#17, and then given people generally shouldn't be passing around riot URLs anyway, it's not a disaster if we encode the URLs 'correctly' with a %23 in them.
Or alternatively we can be thoroughly evil and encode them with a http://www.fileformat.info/info/unicode/char/2317/index.htm instead of a # :>
The text was updated successfully, but these errors were encountered: