Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve history UISI Display #74

Closed
BillCarsonFr opened this issue Dec 16, 2021 · 3 comments
Closed

Improve history UISI Display #74

BillCarsonFr opened this issue Dec 16, 2021 · 3 comments
Assignees
Labels
A-E2EE T-Epic Issue is at Epic level Team: Crypto Z-UISI Unable to decrypt errors

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Dec 16, 2021

Problem description

Currently if you login a new session, all the history messages retrieved via initial sync will be in Error with **unable to decrypt** errors for all messages in timeline.

If the user did verify his session and have a keybackup, a backup import should be happening in background. But during this process the messages would still be displayed with hugly errors. Even key gossiping with the other session could take time.

Actual rendering:
image

Proposal

We should hide undecryptable history if we know that there is no chance for the current device to get the key without a user action (verify, manual import..)
We should hide history while a key backup is in progress, and give feedback on the import process
The user should have an option to show history anyway

image

If the session is verified and the user already did a key import, or if he decided to show message anyway, or if this room is setup to share room key history, we should then show them, but the error level should lowered and a dismissable banner should be shown with details and CTA

image

We should also give feedbacks to the user about the key gossiping process, currently for the user it's like a shot in the dark (re-request encryption keys)

image

Dev Tasks

@amshakal
Copy link

Proposed solution for different usecases:
UISI - User Action Needed

UISI - User Action Needed2

UISI - User Action Needed3

Room template (Web)4

Room template (Web)5

Link to figma: https://www.figma.com/file/a1NWmg6mOi2VZuSgaJx6nD/Displaying-UISI?node-id=112%3A6692

@ShadowJonathan
Copy link

Some feedback; i personally love this variant the most, as it does not hide which messages can be decrypted, which i personally think is a downside of other designs.

@kittykat kittykat added T-Epic Issue is at Epic level A-E2EE labels Jan 12, 2023
@pmaier1
Copy link
Contributor

pmaier1 commented Aug 10, 2023

#249 (comment)

@pmaier1 pmaier1 closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE T-Epic Issue is at Epic level Team: Crypto Z-UISI Unable to decrypt errors
Projects
None yet
Development

No branches or pull requests

6 participants