Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password reset sometimes gives you a 'failed to reset password' error modal when actually it succeeded. #10023

Closed
lampholder opened this issue Jun 12, 2019 · 3 comments

Comments

@lampholder
Copy link
Member

The UX behind the error modal eventually changes to read that the password was updated successfully.

My guess is that this is another instance of Riot polling a registration endpoint and also initiating requests in response to user interface actions - in this case I think the pw reset ux is polling the registration APi, but it is the result of clicking the 'I verified my email' button that appears in the feedback modal. And the password reset API is not idempotent, so if the polling has successfully completed password reset then the button click will fail.

Would it be possible for password reset to be complete upon clicking password reset link? It's easy to miss the final step and think your pw reset failed.

@jryans jryans changed the title Password ResetPassword reset sometimes gives you a 'failed to reset password' error modal when actually it succeeded. Password reset sometimes gives you a 'failed to reset password' error modal when actually it succeeded. Jun 12, 2019
@dbkr
Copy link
Member

dbkr commented Jun 13, 2019

I have no idea how you managed this - there's no polling in the background, it only does the request when you press the, "I verified..." button.

If we're making any significant changes to password reset (by which, read: any that involve spec changes) I'd really like to make it a normal password reset flow, ie. you enter a new password on the page you get after clicking the link.

@jryans jryans added the defect label Jun 17, 2019
@jryans jryans removed the defect label Mar 4, 2021
@richvdh
Copy link
Member

richvdh commented Aug 9, 2021

I think this might have been a dup of #11531?

@Palid
Copy link
Contributor

Palid commented Aug 19, 2021

Duplicate, closing in favor of #11531

@Palid Palid closed this as completed Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants