Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We treat an empty string identity server as not having one #10704

Closed
turt2live opened this issue Aug 30, 2019 · 4 comments
Closed

We treat an empty string identity server as not having one #10704

turt2live opened this issue Aug 30, 2019 · 4 comments

Comments

@turt2live
Copy link
Member

It should default to the client as far as matrix-org/matrix-spec-proposals#2230 is concerned

@turt2live
Copy link
Member Author

actually, @lampholder, what do you think about treating invalid data as null? The spec doesn't really say what we're supposed to do, but I would generally consider invalid as "Disconnected".

@turt2live turt2live added the X-Needs-Product More input needed from the Product team label Aug 30, 2019
@ara4n ara4n added the phase:1 label Sep 26, 2019
@jryans jryans added phase:2 and removed phase:1 labels Oct 15, 2019
@jryans
Copy link
Collaborator

jryans commented Oct 28, 2019

I think it seems reasonable to consider anything falsy or otherwise invalid as the same as null and disconnected.

@turt2live, I believe that's what Riot already does, so is the only task to clarify the spec on this point?

@jryans jryans removed the X-Needs-Product More input needed from the Product team label Oct 28, 2019
@turt2live
Copy link
Member Author

yea, I'm tempted to throw this into spec territory and not riot territory. It's completely reasonable that invalid values be treated as none imo.

@jryans
Copy link
Collaborator

jryans commented Oct 28, 2019

Great, I filed a spec issue we can use to track over there.

@jryans jryans closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants