Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to upload a large profile picture can cause stalls/crashes #11479

Closed
SethFalco opened this issue Nov 22, 2019 · 4 comments
Closed

Trying to upload a large profile picture can cause stalls/crashes #11479

SethFalco opened this issue Nov 22, 2019 · 4 comments
Labels
A-Avatar A-File-Upload Attachments and file uploads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@SethFalco
Copy link

SethFalco commented Nov 22, 2019

Description

If you upload a large file, Riot stalls, and sometimes crashes.
I have tried using a 3.8GB mkv file which causes a crash. And a 1.2GB image file which freezes the application for a while, and eventually responds again with the profile picture not appearing.

Steps to reproduce

  • Open Account Settings
  • Select a large image (or non-image file)

For non image files it simply shouldn't accept it, however for large image files I would expect either a clear file size limit such as 1024KB or 8MB, and for the application to not stop responding during the uploading of the image.

Logs being sent: yes

Version information

  • Platform: Desktop

For the desktop app:

  • OS: Ubuntu 18.04
  • Version: 1.5.3
@SethFalco
Copy link
Author

I don't think common sense justifies this behaviour when it can be programatically handled, for example from the Discord UI, Image is the only File Explorer filter available, if I have a large (1.8GB png) it does force Discord to restart which is not ideal but it's better than just not-responding or becoming a white window.

I could concede this is a low priority, however it's certainly unexpected behaviour that should be addressed.

@jph168
Copy link

jph168 commented Nov 23, 2019

Crashing/nonresponding behavior should be addressed. Being able to select other file formats upon selecting all files is not really a problem in my opinion since most applications restrict formats to the point of having to convert files in order to be readable. I understand you though.

@turt2live turt2live changed the title Large Profile Picture Causing Stall/Crashes Trying to upload a large profile picture can cause stalls/crashes Nov 23, 2019
@532910
Copy link
Contributor

532910 commented Jul 4, 2020

Riot-electron hangs with white screen trying to send the same 200Mb H264 video file, while riot-web in ff works fine.

@MadLittleMods MadLittleMods added A-Avatar A-File-Upload Attachments and file uploads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users labels Aug 24, 2021
@turt2live
Copy link
Member

Duplicate of #4264

@turt2live turt2live marked this as a duplicate of #4264 Jun 14, 2022
@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-File-Upload Attachments and file uploads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants