-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up docs on native Node modules #11517
Labels
T-Task
Tasks for the team like planning
Comments
We now have an auto-build process after #12452, so I suppose all that's left here is to clean up docs on our support for native node modules. |
jryans
changed the title
Improve and validate Seshat building for all desktop platforms
Clean up docs on native Node modules
Apr 24, 2020
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#11125 adds integration and docs for manually enabling Seshat for desktop Riot.
At the moment it recommends:
yarn add matrix-seshat
inelectron_app
for initial installelectron-build-env
for rebuildsThere are a few issues here that leave some room for improvement:
electron-build-env
seems to be ensuring that certain env vars are set, includingnpm_config_runtime
whichneon
seems to need for at least Windowsmatrix-seshat
as a dependency will compile a build for plain Node as part of it's own scripts, but we probably need the adjusted Electron build instead, which may awkwardly mean building it twice withelectron-build-env
from the parent Electron app as wellThe text was updated successfully, but these errors were encountered: