Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff syntax in dark mode is wrong #11553

Closed
dngray opened this issue Nov 28, 2019 · 1 comment
Closed

Diff syntax in dark mode is wrong #11553

dngray opened this issue Nov 28, 2019 · 1 comment
Labels
T-Defect

Comments

@dngray
Copy link

dngray commented Nov 28, 2019

Red should be for removal, green for addition. It is the opposite of light mode, ie what we normally expect.

See screenshot:
diffsyntax
@t3chguy
Copy link
Member

t3chguy commented Nov 28, 2019

Duplicate of #7921

@t3chguy t3chguy marked this as a duplicate of #7921 Nov 28, 2019
@t3chguy t3chguy closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t3chguy @dngray