-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors when uploading key signatures #11574
Comments
When does this happen specifically in the user journey? Does it happen when bootstrapping? (as I see it was referenced in #11212). Can it happen in any other instances? |
I think given the failure mode is that users can't complete their goal— out of pragmatism for now I'd throw up an error message in a modal, where they can hit OK and start doing whatever they were attempting again. If this turns out to be a very common failure mode we could polish this into much nicer contextual error feedback. |
We currently do not check for errors when uploading key signatures (JS SDK method
uploadKeySignatures
). This is probably because the failures are returned inline in the response for each signature, rather than in the top-level HTTP response code.We should track these errors and communicate failure to the user somehow.
The text was updated successfully, but these errors were encountered: