Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room alias validation inconsistent #11737

Closed
bit opened this issue Dec 29, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3807
Closed

Room alias validation inconsistent #11737

bit opened this issue Dec 29, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3807
Assignees
Labels

Comments

@bit
Copy link

bit commented Dec 29, 2019

While creating a room, its possible to set an alias without any restrictions for the local part.
The settings dialog on the other and does not allow slashes in additional aliases.

According to https://github.com/matrix-org/matrix-doc/issues/668 slashes should be allowed.

Both places should use the same alias validation function for a consistent user experience.

matrix-react-sdk/src/components/views/dialogs/CreateRoomDialog.js
matrix-react-sdk/src/components/views/room_settings/AliasSettings.js

the error dialog should state what a valid alias is. right now it just says:

Invalid alias format: 'a/b/c/d/e/f' is not a valid format for an alias.

@bit bit added the T-Defect label Dec 29, 2019
@turt2live
Copy link
Member

Room alias grammar hasn't been fully defined yet, but we should still be consistent within the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants