Uncaught Error: getEventTimeline result didn't include requested event

[matrixbot]

Created by @ matthew:matrix.org.

on trying to load https://vector.im/develop/#/room/#purple:matrix.org/%241451504230525382RHTLB:matrix.org

[richvdh]

We're not expecting %-encoding in the path - this is true as much for the room name as the event ID. The link you're after is https://vector.im/develop/#/room/#purple:matrix.org/$1451504230525382RHTLB:matrix.org.

So, three questions:

• Should we %-decode the fragment id? (probably?)
• Why is synapse not 404-ing the /context request despite the resultant double-%-encoding
• Should we prioritise the error-handling for /context links higher than p2 (We get a blank screen when a context link fails to load #979)

[richvdh]

We should absolutely %-decode the fragment: rfc3986 makes it clear that % can only be followed by two hex digits, even in the fragment.

[richvdh]

Fixed by #1254