Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the history visibility as part of room creation process shouldn't be displayed in the timeline #1269

Closed
AmandineLP opened this issue Mar 24, 2016 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3433
Assignees
Labels
P1 S-Tolerable Low/no impact on users

Comments

@AmandineLP
Copy link
Contributor

When creating a room, the timeline shows "Amandine made future room history visible to all room members." just after "Amandine joined the room.". Given I didn't explicitly set the history visibility but it set itself by default it probably shouldn't be shown in the timeline.

The only reason to do it would be to make clear what is the current setting.

In that case let's improve the wording and not say a user set it but something like "The future room history visible to all room members" and possible do the same with other important settings like "Only people who have been invited can access this room". And display it before the event saying the room creator joined the room (which also feels a bit clunky as really exposing how the tech works behind, but I'm not entirely sure it should be removed yet).

Let's discuss about the conclusion: remove the event from the timeline or improve it.

@ara4n
Copy link
Member

ara4n commented Mar 29, 2016

Agreed. I think we should just remove it, given all rooms share their history by default in vector.

@t3chguy
Copy link
Member

t3chguy commented Sep 10, 2019

Related to #8830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Tolerable Low/no impact on users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants