Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSSS upload can fail during bootstrap leaving the account in a broken state #13216

Open
dbkr opened this issue Apr 16, 2020 · 10 comments
Open

SSSS upload can fail during bootstrap leaving the account in a broken state #13216

dbkr opened this issue Apr 16, 2020 · 10 comments
Assignees

Comments

@dbkr
Copy link
Member

dbkr commented Apr 16, 2020

We upload public keys and then upload the private ones to SSSS (secure secret storage and sharing): if the latter fails then we end up in an inconsistent state, especially if we were resetting in which case we have different keys in each place

@jryans
Copy link
Collaborator

jryans commented Apr 16, 2020

Seems nice to have fixed for release, but not a blocker.

@non-Jedi
Copy link

Is my reading of this correct that there's no longer any value for debugging in maintaining my account in the broken state, and I should just go ahead and reset cross-signing?

@jryans
Copy link
Collaborator

jryans commented Apr 16, 2020

Is my reading of this correct that there's no longer any value for debugging in maintaining my account in the broken state, and I should just go ahead and reset cross-signing?

Yes, I think we've learned all we'll learn from the forensics you and @fladd reported in #12959, so feel free to reset now and file any further issues from there. Thanks for the help testing this! 😄

@fladd
Copy link

fladd commented Apr 16, 2020

Except that resetting doesn't work... #13212

So no, don't reset yet! Wait for the resetting mechanism to be fixed. Otherwise you end up in yet another broken state.

@jryans
Copy link
Collaborator

jryans commented Apr 17, 2020

Except that resetting doesn't work... #13212

This is now fixed on develop, so if you're able to try that, if would be useful to use it and reset for verification.

@non-Jedi
Copy link

non-Jedi commented Apr 17, 2020

After resetting cross-signing keys, verification was successful on riot.im/develop between the two devices mentioned in #12959. :)

@bwindels bwindels self-assigned this Apr 17, 2020
@bwindels
Copy link
Contributor

I guess retrying would be a good start, and if it keeps failing, show a notification somehow in the interface that other devices won't be able to cross-sign (and that you could lose your signing capability altogether if your session gets hosed)

@bwindels
Copy link
Contributor

bwindels commented Apr 17, 2020

Has some relation #13169

@bwindels
Copy link
Contributor

Might warrant creating some generic retrying infrastructure (with some backoff) in the js-sdk

We might also want a toast while you're in the broken state.

@bwindels
Copy link
Contributor

We're retrying the account data requests up to 5 times now, with an exponential backoff. This should be enough of an improvement for phase:3

Leaving this open, as if they'd still fail after 5 retries, we'd still end up in the broken state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants