-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSSS upload can fail during bootstrap leaving the account in a broken state #13216
Comments
Seems nice to have fixed for release, but not a blocker. |
Is my reading of this correct that there's no longer any value for debugging in maintaining my account in the broken state, and I should just go ahead and reset cross-signing? |
Yes, I think we've learned all we'll learn from the forensics you and @fladd reported in #12959, so feel free to reset now and file any further issues from there. Thanks for the help testing this! 😄 |
Except that resetting doesn't work... #13212 So no, don't reset yet! Wait for the resetting mechanism to be fixed. Otherwise you end up in yet another broken state. |
This is now fixed on develop, so if you're able to try that, if would be useful to use it and reset for verification. |
After resetting cross-signing keys, verification was successful on riot.im/develop between the two devices mentioned in #12959. :) |
I guess retrying would be a good start, and if it keeps failing, show a notification somehow in the interface that other devices won't be able to cross-sign (and that you could lose your signing capability altogether if your session gets hosed) |
Has some relation #13169 |
Might warrant creating some generic retrying infrastructure (with some backoff) in the js-sdk We might also want a toast while you're in the broken state. |
We're retrying the account data requests up to 5 times now, with an exponential backoff. This should be enough of an improvement for Leaving this open, as if they'd still fail after 5 retries, we'd still end up in the broken state. |
We upload public keys and then upload the private ones to SSSS (secure secret storage and sharing): if the latter fails then we end up in an inconsistent state, especially if we were resetting in which case we have different keys in each place
The text was updated successfully, but these errors were encountered: