Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a tombstone event in favor of an existing room lead to two annoying side effects #14532

Closed
bmarty opened this issue Jul 16, 2020 · 6 comments
Labels

Comments

@bmarty
Copy link
Member

bmarty commented Jul 16, 2020

I observe this by sending a tombstone event to RiotX android room and link the tombstone event to Element-Android room.

It's maybe some sort of a hack usage of tombstone event though.

Steps:

  • Send a tombstone event to RoomA including the id of an existing room RoomB

First small bug:

RoomA claims that the room has been upgraded. This is not the case.

First side effect:

Clicking on the link of tombstone event rendering in RoomA send the user to the beginning of RoomB (the create event). In this case, as this is not a room upgrade, user should should land to the latest message of RoomB

Second side effect:

Leaving RoomA makes the app also leaves RoomB which is quite annoying.
RoomB's create event does not refer to RoomA as a predecessor, so in this case RoomB should not be left automatically.

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2020

2nd side effect is #10380

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2020

RoomA claims that the room has been upgraded. This is not the case.

Isn't it?

https://matrix.org/docs/spec/client_server/r0.6.1#id160 m.room.tombstone is listed in the Room Upgrades section.

One way of accomplishing this would be hiding the old room from the user's room list and showing banners linking between the old and new room - ensuring that permalinks work when referencing the old room.

@turt2live
Copy link
Member

Yea, unfortunately we're not able to tell the difference between a redirect and an upgrade. Abusing tombstones for this purpose is generally not recommended, and the people who did recommend this approach will have known that it'll be counted as an upgrade.

@bmarty
Copy link
Member Author

bmarty commented Jul 16, 2020

RoomA claims that the room has been upgraded. This is not the case.

True, sorry, I've seen that on RiotX

@bmarty
Copy link
Member Author

bmarty commented Jul 16, 2020

Yea, unfortunately we're not able to tell the difference between a redirect and an upgrade

The m.room.create does not contains a predecessor in case of a redirect.

@turt2live
Copy link
Member

The m.room.create does not contains a predecessor in case of a redirect.

From a spec perspective, this is an invalid event not a redirect. Redirects are not a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants