Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link must be emphasized on mouse over #15252

Closed
532910 opened this issue Sep 21, 2020 · 6 comments
Closed

link must be emphasized on mouse over #15252

532910 opened this issue Sep 21, 2020 · 6 comments

Comments

@532910
Copy link
Contributor

532910 commented Sep 21, 2020

All ways are good: underline, bold...

image
What link will be opened by click?

@t3chguy
Copy link
Member

t3chguy commented Sep 21, 2020

What apps do that?

@532910
Copy link
Contributor Author

532910 commented Sep 21, 2020

All good web sites emphasizes links on mouse over.
The screenshot is from latest element and in firefox it looks the same.

@532910
Copy link
Contributor Author

532910 commented Sep 21, 2020

End even tilix and urxvt underline links.

@fooness
Copy link
Contributor

fooness commented Sep 23, 2020

Some links are correctly underlined when hovering or focusing them … and I don’t figure out why others aren’t.

bundle.css:

.markdown-body a:active, .markdown-body a:focus, .markdown-body a:hover {
  text-decoration: underline;
}

But I agree to OP, there should be an indication (underline) when hovering or focusing links. (font-weight variations aren’t a good idea, as also the width is increased and this will cause flickering.)

@532910
Copy link
Contributor Author

532910 commented Sep 23, 2020

I don’t figure out why others aren’t.

.markdown-body a:active, .markdown-body a:focus, .markdown-body a:hover {
  text-decoration: underline;
}

This is the answer: markdown links are underlined, other --- not.

font-weight variations aren’t a good idea, as also the width is increased and this will cause flickering.

Agree, but a color change will be fine too. Though markdown links are already underlined, all links must be underlined, as consistent behaviour is a priority.

@robintown
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#6513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants