Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The share dialog looks ugly #15562

Open
notramo opened this issue Oct 26, 2020 · 11 comments
Open

The share dialog looks ugly #15562

notramo opened this issue Oct 26, 2020 · 11 comments
Labels
A-Matrix.to A-Share O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement X-Needs-Design Z-AccountResurrection Delight - cycle

Comments

@notramo
Copy link

notramo commented Oct 26, 2020

This dialog design has been updated and the designs are here: https://docs.google.com/spreadsheets/d/1SAcCgnHoze9Flqx-XXkC0B8iQyLnpylv2z4iidK0v-8/edit#gid=42666095&range=B32:C32


Maybe it should be replaced with a QR code and "Copy to clipboard" button. Using predefined social media links is unnecessary, as people can easily paste the link from the clipboard anywhere they want (and the current list doesn't include decentralised platforms, e.g. Mastodon, Friendica).
share

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2020

Something funky going on with yours
image

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2020

Also you can hide the social icons already if you don't like them. https://github.com/vector-im/element-web/blob/develop/docs/config.md#ui-features

UIFeature.shareSocial

@notramo
Copy link
Author

notramo commented Oct 26, 2020

@t3chguy Mine is on narrow screen. But yours is ugly too.
E.g. why is that horizontal line there?
Why doesn't the social media icons fit into their circles?

@niquewoodhouse
Copy link

Can anyone see a reason why the share dialog and invite dialog are two separate dialogs? From a user's perspective, I think they're the same goal - share the room somehow, so wonder if combining them would be a good way to make it simpler for users and look nicer overall.

On discord it's one dialog

image

On Pinterest it's one dialog

image

Something like this for public rooms might work, just combining the share and invite dialog.

invite dialog 2@2x

@robintown
Copy link
Member

@niquewoodhouse I was thinking of implementing that design, however there's still the question of what to do with the 'Share message' dialog, as well as what the invite dialog should look like if the user doesn't have invite permissions for the room (pretty common for public rooms these days). Do you think the dialog should only consist of the single row of buttons in those cases, or would a different design be preferable?

@SimonBrandner
Copy link
Contributor

@robintown, there is another issue which talks about this in more detail. As it happens I am also interested in this 😅 Anyway, the designs aren't finished yet (again more detail in #16457). Would you mind waiting for the designs and deciding then who's going to do it based on the circumstances?

@robintown
Copy link
Member

@SimonBrandner Ah I didn't even see that other issue 😅 If you're already interested then I'll of course leave it to you

@SimonBrandner
Copy link
Contributor

When a design appears I might not have enough time for this, so I might be happy to leave it to you :P

@ShadowJonathan
Copy link
Contributor

One request i have with this approach; Could i still have the option for a "dumb" click-to-copy-link or ID? I would like to directly link something, or get something's ID, without going through such a window. Though maybe thats developer-me speaking out loud there 😅

@daniellekirkwood
Copy link
Contributor

@gaelledel
Copy link

FYI I redesigned the share dialogs as part of the permalinks project https://www.figma.com/file/2qAtUobdikIwVBFHmZcLvb/Permalinks?node-id=1-4&t=5G2yDTQJJ2YIYxrU-4

@amshakal amshakal removed their assignment Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Matrix.to A-Share O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement X-Needs-Design Z-AccountResurrection Delight - cycle
Projects
None yet
Development

No branches or pull requests