Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji picker has jumpy scroll jitter (x) #15940

Closed
MadLittleMods opened this issue Dec 9, 2020 · 5 comments
Closed

Emoji picker has jumpy scroll jitter (x) #15940

MadLittleMods opened this issue Dec 9, 2020 · 5 comments
Labels
A-Emoji O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@MadLittleMods
Copy link
Contributor

Description

When filtering for the :x: ❌ emoji and scrolling to the bottom, the picker will jitter a couple pixels up and down continuously whenever you're touching the bottom.

Steps to reproduce

  1. Filter for x in the emoji picker
  2. Scroll down to the bottom
  3. Notice the jumpy scroll jitter whenever you are at the bottom

Log: not sent

Version information

I can't reproduce on macOS.

@tulir
Copy link
Contributor

tulir commented Aug 2, 2021

This happened to me: I have 🥈 in frequently used and tried to search for "2" to react with 2️⃣. The 2️⃣ is at the bottom, but due to that scroll/lazy loading bug, I can't actually click it (it shows up in the large preview at the bottom, but isn't clickable because it disappears from the picker itself)

peek.mp4

Firefox 91.0b9 on Ubuntu 21.04

@anoadragon453
Copy link
Member

Still occurs with Element stable 1.7.34. It prevents me from picking some emoji at the bottom, specifically the US flag when searching for "us".

@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 S-Tolerable Low/no impact on users labels Aug 10, 2021
@t3chguy
Copy link
Member

t3chguy commented Nov 29, 2021

Is this still reproducible on latest develop? There was a lazy render bug which may have been related but now fixed.

@tulir
Copy link
Contributor

tulir commented Nov 29, 2021

Seems to be fixed. The lazy rendering is a bit too lazy though (it hides emoji if even 1 pixel of it is out of bounds, rather than if it's entirely out of bounds)

@MadLittleMods
Copy link
Contributor Author

I can no longer reproduce either (and I could reproduce before refreshing today).

Fix for reference: matrix-org/matrix-react-sdk#7225

Thanks @t3chguy 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants