Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressing 'up' to edit a message doesn't jump the edit box into view if you're scrolled up. #16402

Closed
ara4n opened this issue Feb 8, 2021 · 7 comments

Comments

@ara4n
Copy link
Member

ara4n commented Feb 8, 2021

i'd expect when you focus the edit box for it to become visible

@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2021

Cannot reproduce, it scrolls into view for me.

Screen.Recording.2021-04-13.at.11.34.50.mov

@SimonBrandner
Copy link
Contributor

I can repro this if I am scrolled up enough that the message isn't in the paginated area (I hope that's how it's called)

@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2021

So if the app doesn't have a recent message from you loaded then that's expected, but the issue there isn't about scrolling but that it just does nothing, no?

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Apr 13, 2021

I am not sure I understand, steps to repro my issue:

  • Go to a room with a bunch of traffic
  • Send a message
  • Scroll up until the message isn't in the loaded area
  • Press up arrow - you won't get scrolled down to see the message

If this isn't what this issue is about, I misunderstood - sorry

@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2021

Right, if you scroll enough for that event to be paged-out of memory then that is expected, we only check the local timeline and not ask the server to find the message to edit

Though it probably shouldn't, the live timeline should be maintained, looks to get capped at 254 events but that should be plenty for your reply to be within, probably needs more investigation

@SimonBrandner
Copy link
Contributor

Ah, that makes sense. This means I can't repro either

@t3chguy
Copy link
Member

t3chguy commented Jul 10, 2023

Closing due to unable to reproduce

@t3chguy t3chguy closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants