Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌘A on AZERTY keyboards open "Close Element" Popup #16938

Closed
PommeAuMiel opened this issue Apr 13, 2021 · 9 comments · Fixed by element-hq/element-desktop#185
Closed

⌘A on AZERTY keyboards open "Close Element" Popup #16938

PommeAuMiel opened this issue Apr 13, 2021 · 9 comments · Fixed by element-hq/element-desktop#185
Assignees
Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker Z-Platform-Specific

Comments

@PommeAuMiel
Copy link

Hi guys !

Description

Shortcut ⌘A (Select All) on macOS with Element Desktop Version 1.7.25 open a "Close Element" Popup instead of select all text.
It look like this issue is present not only on macOS, i try it on Debian 10, with french AZERTY also.

When i switch to QWERTY keymap, when i physically press ⌘Q (so ⌘A) it done good shortcut "select all".

Shortcut on Element macOS app :
Capture d’écran 2021-04-13 à 19 23 51
Capture d’écran 2021-04-13 à 19 24 40

Steps to reproduce

  • Switch to non-US QWERTY keyboard or use AZERTY mapping
  • Open Element Desktop
  • Press ⌘A (or ctrl A on Windows/Linux)

This popup appears
Capture d’écran 2021-04-13 à 18 42 52

This happen everywhere i click on the Element Window.

Version information

For the desktop app:
Test on:

  • OS: macOS, Debian 10
  • Version: 1.7.25

Thanks :)

@flyx
Copy link

flyx commented Apr 14, 2021

The same thing happens when using the Neo layout on macOS and pressing ⌘X which should cut the currently selected text but instead opens this dialog.

Interestingly, the dialog is not shown when physically selecting Quit Element in the menu or hitting ⌘Q – in that case, Element simply closes.

@baptistefluzin
Copy link

Same issue, same element version, win 8.1, AZERTY keyboard, french language on. This is very annoying.

@Flandre5carlet
Copy link

Flandre5carlet commented Apr 15, 2021

Same problem on Windows 10; CTRL+A on a physical AZERTY keyboard opens up the "Are you sure you want to quit?" popup.

However interestingly enough, even when selecting "Close Element", it doesn't actually close anything for me, and selects all afterwards. It doesn't select anything when clicking "Cancel" on the popup.
It feels like it only "half-registers" CTRL+A as CTRL+Q instead (because of the key's position) - enough to show the quit confirmation prompt, but not enough to register it as a quit command so it ends up being a select all confirmation.

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Apr 15, 2021

I can not repro on Linux (Debian 11 Bullseye, KDE+i3wm) /me is an idiot and has missed the whole keyboard layout thing

@Adrien-Luxey
Copy link

Adrien-Luxey commented Apr 15, 2021

Same issue on Linux Mint, Element Desktop v1.7.25, AZERTY (precisely: French "variant")
The bug doesn't trigger when I set my keyboard layout to QWERTY (En-US).

Takeaway would be: it might not be a platform-specific bug, but a keyboard-layout-specific one.
Wondering how you devs found this bizarre behaviour x)

@nicolasgavalda
Copy link

Same issue after updating Element Desktop from 1.7.24 to 1.7.25 on ubuntu 20.04, AZERTY keyboard layout (French variant).

@Thatoo
Copy link

Thatoo commented Apr 15, 2021

Same issue with CTRL+A after updating Element Desktop from 1.7.24 to 1.7.25 on Debian 10, AZERTY keyboard layout (French variant).

@SimonBrandner SimonBrandner added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 15, 2021
@germain-gg germain-gg self-assigned this Apr 15, 2021
@germain-gg
Copy link
Contributor

germain-gg commented Apr 15, 2021

Désolé 😅

Thank you for reporting this issue, I have just opened a PR and this should cater for all keyboard layout.
It will probably land in the Nightly build tomorrow, and be available when Element v1.7.26 goes out

Edit: in the meantime... you can deactivate the prompt by going to your user preferences

  • All settings > Preferences > General > Warn before quitting

@Adrien-Luxey
Copy link

Well that was fast, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker Z-Platform-Specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants