Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate rooms in sidebar list #17492

Closed
callahad opened this issue May 28, 2021 · 5 comments
Closed

Duplicate rooms in sidebar list #17492

callahad opened this issue May 28, 2021 · 5 comments
Labels

Comments

@callahad
Copy link

callahad commented May 28, 2021

Description

When switching rooms, duplicates occasionally appear in the room list.

Screen Shot 2021-05-28 at 10 07 30

Screen Shot 2021-05-28 at 10 07 24

Steps to reproduce

I haven't determined specific STRs yet, but I've hit this ~5 times over the past 12 hours, including for both normal rooms and DMs. I've even managed to create three duplicates of a room at once.

Duplicates are not always grouped together (per second screenshot).

Switching to a different room and changing Spaces fixes the rendering to show only a single entry.

All duplicate entries behave as expected.

I suspect it involved being in one space, hitting ctrl-k, and selecting a room that only exists in another space.

Version information

  • Platform: web

For the web app:

  • Browser: Firefox Beta (89)
  • OS: macOS
  • URL: develop.element.io
@t3chguy
Copy link
Member

t3chguy commented May 28, 2021

Duplicate of #14508

@t3chguy t3chguy marked this as a duplicate of #14508 May 28, 2021
@t3chguy t3chguy closed this as completed May 28, 2021
@t3chguy
Copy link
Member

t3chguy commented May 28, 2021

Also interesting Stylus/usermod you're running there

@callahad
Copy link
Author

Here's the Stylus export, derived from this comment on #14099 :)

@-moz-document domain("develop.element.io"), domain("app.element.io") {

section#matrixchat .mx_LeftPanel .mx_RoomList .mx_RoomTile {
    margin-bottom: 0;
    padding: 1px;
}


section#matrixchat .mx_LeftPanel .mx_RoomList .mx_RoomTile .mx_DecoratedRoomAvatar .mx_BaseAvatar_initial,
section#matrixchat .mx_LeftPanel .mx_RoomList .mx_RoomTile .mx_DecoratedRoomAvatar .mx_BaseAvatar_image {
    width: 16px !important;
    height: 16px !important;
    font-size: 10.4px !important;
    line-height: 16px !important;
}


section#matrixchat .mx_LeftPanel .mx_RoomList .mx_RoomTile .mx_RoomTile_menuButton,
section#matrixchat .mx_LeftPanel .mx_RoomList .mx_RoomTile .mx_RoomTile_notificationsButton {
    width: 16px;
    height: 16px;
}

.mx_RoomSublist .mx_RoomSublist_resizeBox .mx_RoomSublist_tiles {
    flex: none;
}

.mx_RoomSublist .mx_RoomSublist_resizeBox {
    height: unset !important;
}

.mx_RoomSublist .mx_RoomSublist_resizeBox .mx_RoomSublist_resizerHandles {
    display: none;
}

.mx_DecoratedRoomAvatar .mx_DecoratedRoomAvatar_icon,
.mx_TemporaryTile .mx_DecoratedRoomAvatar_icon {
  right: -4px;
}

.mx_RoomBreadcrumbs_crumb .mx_DecoratedRoomAvatar_icon {
  right: -2px;
}

.mx_RoomSublist.mx_RoomSublist_minimized .mx_RoomSublist_headerContainer .mx_RoomSublist_auxButton {
  width: 16px !important;
  height: 16px !important;
}

.mx_RoomSublist.mx_RoomSublist_minimized .mx_RoomSublist_headerContainer .mx_RoomSublist_auxButton::before {
  top: 0px;
  left: 0px;
}

}

@niquewoodhouse
Copy link

@callahad do you ever have the message previews turned on with that view? just curious, thanks

@callahad
Copy link
Author

@niquewoodhouse I don't, but message previews seem to work well enough aside from a misalignment of the public room icon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants