-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache and gradually fill Explore rooms
#17550
Comments
Explore rooms
Explore rooms
This is still pretty bad on a recent-ish Synapse (1.51.0) and Element Desktop 1.10.6. Searching the Element Corp space for I noticed that each In any case, I think the priority of this should be bumped; a first time user waiting for over a minute for some search results is not a very good user experience if we want spaces to be a serious organizational tool. |
The reason the pages requested are relatively small are for the UI to be snappier when scrolling, the mechanism for scrolling vs loading for filtering is identical so differentiating the intent is non-trivial. Ideally there'd be an MSC for the filtering to be done by the server, like for the /publicRooms API.
I doubt the requests are the overhead here, its that the server computing this requires a lot of work and thus is slow, with the way the pagination works the server would be caching things so that the request overhead would be negligible. |
Would increasing the number of results from 20 to 100 really make a significant difference in response times? Running a few manual measurements from the command line with curl doesn't show much difference.
Empirically, from my testing, this looks to be wrong. Each request takes about 3-5 seconds to complete even when completed in quick succession and response times do not vary significantly with the number of results requested. Note that this is on Synapse 1.51.0. Reportedly this was improved a bit in 1.54.0, which I've yet to test, so the point may be moot.
I'm reluctant to rely on the server too much since it will make it harder or prevent us from ever encrypting more information, such as room names. If it can be done, it's far preferable to fine-tune requests and implement caching so that this can be done efficiently in a completely client-side manner. |
This is already an issue with /publicRooms. |
Indeed, but:
|
Just an extra data point - it took me a few seconds shy of three minutes to find a room in the Element space over federation. I:
I don't usually use the feature because it's so slow - on this occasion I needed to find the room through searching, so I waited the wait. |
Is your suggestion related to a problem? Please describe.
An example is in the
Matrix community
space or any of its subspaces. When you hit explore rooms it take ages for it to load, and when you switch back and forth these have to be fetched again.Describe the solution you'd like.
The text was updated successfully, but these errors were encountered: