Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement device trust view in user settings #17767

Closed
dbkr opened this issue Jun 24, 2021 · 7 comments · Fixed by matrix-org/matrix-react-sdk#7004
Closed

Implement device trust view in user settings #17767

dbkr opened this issue Jun 24, 2021 · 7 comments · Fixed by matrix-org/matrix-react-sdk#7004
Assignees
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement

Comments

@dbkr
Copy link
Member

dbkr commented Jun 24, 2021

Currently it's only in your own user profile view in the room sidebar & we direct the user there to do things like verify

@jryans
Copy link
Collaborator

jryans commented Jun 25, 2021

#11221 is a related issue for the 2019 device list designs that covered this area and more.

We should definitely add this one way or another, as it will greatly improve the feel of the app and resolve a lot of confusion.

@dbkr
Copy link
Member Author

dbkr commented Sep 1, 2021

Designs for this are in the 'cross signing' figma under 'settings' which I really wish I knew how to get a link to from figma

@SimonBrandner SimonBrandner added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Sep 1, 2021
@jryans
Copy link
Collaborator

jryans commented Sep 1, 2021

I really wish I knew how to get a link to from figma

After selecting a nearby frame, on the web, you can just copy the address bar. On desktop, you may need to use top-right Share button -> Copy link.

I believe https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=6%3A364 is pointing near the right place.

@amshakal
Copy link

amshakal commented Sep 3, 2021

I updated the design based on the new design system

https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=7698%3A113101

@dbkr dbkr added this to the App Team 1.8.4 milestone Sep 8, 2021
@duxovni duxovni self-assigned this Sep 17, 2021
@novocaine novocaine modified the milestones: App Team 1.8.6, App Team 1.8.7 Sep 22, 2021
@kittykat
Copy link
Contributor

@amshakal would it be possible to trigger verification from that setting panel for an unverified device? The issue of it being difficult to re-trigger verification came up in our community testing session last week.

@duxovni
Copy link
Contributor

duxovni commented Sep 30, 2021

I feel like that'd be pretty easy to include alongside the Rename/Sign Out buttons for unverified devices, I'll proceed in that direction pending feedback.

@amshakal
Copy link

Yeah, I agree, that would be useful. @duxovni we can look at the flow together if you like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants