Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom notification sound file upload visible in room settings #18392

Closed
turt2live opened this issue Aug 4, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11415
Closed
Assignees
Labels
A-Notifications A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-GetYourUpdates

Comments

@turt2live
Copy link
Member

It's supposed to be managed by the buttons

@daniellekirkwood
Copy link
Contributor

Screenshot 2023-08-15 at 17 20 28

This is as designed. Give or take some Compound tweaks.

@turt2live I don't follow your ask but I think it's covered as you can control the sound of a room using the buttons. I'll close this but re-open if you have more details to add and my understanding is not correct.

@turt2live
Copy link
Member Author

@daniellekirkwood this is a bug, imo.

image

From your screenshot, the "Browse" button does the job of opening a file picker. The "Choose file [no file chosen]" bit is supplied by the browser, and looks bad. When the user selects a sound, we also add our own line of text:

image

The "Choose file" browser-supplied file picker should be hidden, as all the functionality is available with branded/proper buttons.

@t3chguy
Copy link
Member

t3chguy commented Aug 16, 2023

Pretty sure this is an old regression actually

@t3chguy t3chguy self-assigned this Aug 16, 2023
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-GetYourUpdates
Projects
None yet
5 participants