Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new DMs you initiate appear in breadcrumbs with an initial of 'E', no matter who they're with #18485

Closed
ara4n opened this issue Aug 11, 2021 · 7 comments
Labels
A-Avatar A-Breadcrumbs A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce

Comments

@ara4n
Copy link
Member

ara4n commented Aug 11, 2021

i assume E stands for Empty Room. it should use the profile of the user you're DMing instead, obviously

@SimonBrandner SimonBrandner added A-Avatar A-Breadcrumbs A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Aug 11, 2021
@germain-gg
Copy link
Contributor

I tried reproducing this issue on develop.element.io and was not able to
Not quite sure what to do next. Any chance you could share a little more information regarding this?

@ara4n
Copy link
Member Author

ara4n commented Aug 12, 2021

hm, agreed. i guess it's possible i'm getting it mixed up with #16400, but i'm pretty sure that 3 times in a row i saw the new DM being added to breadcrumbs but with an E. In trying to repro it just now i captured #16400 instead. as per #16400 (comment)

@t3chguy
Copy link
Member

t3chguy commented Aug 12, 2021

It could also be related to the js-sdk bug (now fixed) with sentinel members/event contexts which caused the name/avatar to lag behind and might've bled through to room avatar/name calculation

@ara4n
Copy link
Member Author

ara4n commented Aug 12, 2021

if that was fixed in today's nightly build, that might explain why i can't repro now.

@t3chguy
Copy link
Member

t3chguy commented Aug 12, 2021

Merged 2 days ago matrix-org/matrix-js-sdk#1837 so potentially not

@ara4n
Copy link
Member Author

ara4n commented Aug 12, 2021

right, i was on today's nightly, so i bet this is what was causing this.

@ara4n ara4n closed this as completed Aug 12, 2021
@ara4n
Copy link
Member Author

ara4n commented Sep 10, 2021

no, it's still happening. however, turns out this is a duplicate of #17480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Breadcrumbs A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce
Projects
None yet
Development

No branches or pull requests

4 participants