Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix room notifications count for threaded events #19126

Closed
4 of 7 tasks
germain-gg opened this issue Sep 22, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7298
Closed
4 of 7 tasks

Fix room notifications count for threaded events #19126

germain-gg opened this issue Sep 22, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7298
Assignees
Labels
A-Threads T-Task Tasks for the team like planning

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Sep 22, 2021

For the first iteration, read receipts and read markers will not be supported for Threads.
At the moment when a new event is received, this will increment the notification count.

However, upon viewing the "thread view" read receipts are disabled, therefore the notification count is never disabled.

Splitting events across different timeline sets breaks the contract that all events are in chronological order. Meaning that the way read receipts work is not entirely correct anymore

Design: figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=1246%3A231502

Requirements

  • When receiving a new threaded event the notification count should increase by 1
  • When mentioned in a thread the notification pill color should turn to red
  • When opening a room only the events in visible timelines should be decremented from the room's notification count
  • Upon opening a thread, if it contains any unread messages, decrement the room notification count
  • if notification count is only related to one thread, open the thread view when switching to that room
  • if notification count is related to 2+ threads, open the room and the threads list
  • if notification count is related to main timeline only, keep the same behaviour as pre-thread
@germain-gg germain-gg added T-Task Tasks for the team like planning A-Threads labels Sep 22, 2021
@germain-gg germain-gg self-assigned this Sep 22, 2021
@germain-gg germain-gg added this to the App Team 1.8.7 milestone Sep 22, 2021
@germain-gg germain-gg added the X-Needs-Product More input needed from the Product team label Oct 19, 2021
@daniellekirkwood
Copy link
Contributor

We discussed this today and landed here:

  • We will implement notifications in a way that includes numbers (and colours) in the notification badges
  • Users may have a notification on each platform they have Threads on, this is a temporary compromise we are willing to make (it's better to have a notification twice, than miss something completely)
  • The goal is to implement this in such a way that very little work is needed on Client side once Server supports read receipts

@gsouquet did I capture this correctly?

@daniellekirkwood
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads T-Task Tasks for the team like planning
Projects
None yet
3 participants