Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files drag and drop file in a room work with threads #19578

Closed
Tracked by #61
germain-gg opened this issue Nov 1, 2021 · 8 comments · Fixed by matrix-org/matrix-react-sdk#7860
Closed
Tracked by #61
Assignees
Labels
A-File-Upload Attachments and file uploads A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement T-Task Tasks for the team like planning Z-Labs

Comments

@germain-gg
Copy link
Contributor

If a file is dropped over the thread view, upload the file in the thread, otherwise upload it in the room.

Adding @janogarcia to the discussion as we might want to have some visuals to indicate in what context a file will be uploaded

@daniellekirkwood
Copy link
Contributor

Removing the Blocked status as we have discussed this issue. This is a nice-to-have for the MVP and so has been put into the Threads:Post Launch Epic.

As we get closer to launching Threads MVP, we will reconsider this decision.

@daniellekirkwood daniellekirkwood removed X-Needs-Design X-Needs-Product More input needed from the Product team labels Nov 11, 2021
@HarHarLinks
Copy link
Contributor

At the same time, this could (imo, should) also add the ability to reply with a file upload

@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2021

Replies (non thread) with files is not possible due to the spec's requirement of a fallback which is not possible when sending files.

@HarHarLinks
Copy link
Contributor

aren't threads (supposed to?) fall back to replies? what's the difference then?
getting rid of reply fallbacks is a whole other issue

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2021

Threads have no fallback, if Threads fell back to replies then you couldn't reply to a thread so it was decided that they do not fall back to replies.

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Nov 22, 2021

Sorry, what I mean is: in current element with the labs flag I can write into a thread, but turning the labs flag off it will appear as a regular reply. I had assumed that for this same reason you can only post such events into a thread which you can post as a reply. It might be an element implementation prototyping off-spec quirk instead.

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2021

but turning the labs flag off it will appear as a regular reply.

Yup, but if you use an old (pre-Threads) Element that wouldn't happen.
This is just the Element receiver treating threads with the Replies code with the labs flag off

@HarHarLinks
Copy link
Contributor

Then with threads merged into spec, clients will be expected to implement them, no fallback? If that is the case, I don't see a reason to not require proper replies and remove reply fallbacks at the same time. Anyway, this is getting off-topic.

Files-as-reply for all.

@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement T-Task Tasks for the team like planning and removed T-Task Tasks for the team like planning labels Dec 14, 2021
@t3chguy t3chguy assigned t3chguy and unassigned t3chguy Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-File-Upload Attachments and file uploads A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement T-Task Tasks for the team like planning Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants