Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary vertical top padding in thread view #19580

Closed
Tracked by #3
novocaine opened this issue Nov 2, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7220
Closed
Tracked by #3

Unnecessary vertical top padding in thread view #19580

novocaine opened this issue Nov 2, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7220
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Milestone
App team 1.9.6

Comments

@novocaine
Copy link
Contributor

Steps to reproduce

Create a new thread

Outcome

There's excessive vertical padding at the top of the thread view, causing an unnecessary vertical scroll bar to appear

Screenshot 2021-11-02 at 09 13 38

  • scroll up to nothing *

Screenshot 2021-11-02 at 09 13 42

Operating system

os X

Browser information

Chrome

URL for webapp

develop.element.io

Application version

Nightly

Homeserver

matrix.org

Will you send logs?

No
@germain-gg germain-gg added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 2, 2021
@germain-gg germain-gg self-assigned this Nov 2, 2021
@germain-gg germain-gg mentioned this issue Nov 4, 2021
Closed
@germain-gg
Copy link
Contributor

@t3chguy are you aware of why the timeline adds overscroll? i'm not sure i understand the reasoning behind that

@germain-gg germain-gg added this to the App team 1.9.6 milestone Nov 29, 2021
@germain-gg germain-gg mentioned this issue Nov 29, 2021
Merged
@germain-gg germain-gg mentioned this issue Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
App team 1.9.6
Development

Successfully merging a pull request may close this issue.

Hide scrollbar if content height is smaller than scroll node height matrix-org/matrix-react-sdk
2 participants
@novocaine @germain-gg