Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for room alias addresses #19730

Open
Palid opened this issue Nov 12, 2021 · 4 comments
Open

Better error handling for room alias addresses #19730

Palid opened this issue Nov 12, 2021 · 4 comments
Labels
A-Aliases A-Room-Settings Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement

Comments

@Palid
Copy link
Contributor

Palid commented Nov 12, 2021

Your use case

Followup to #19609 as currently there's a very generic modal/popup if there's any kind of an error and that's very unhelpful.
We should show a humanized (and definitely not developer-humanized, like it is being returned from backend) version of the errors in the modal windows instead, so that the user knows what really happened there and how to fix it.

What would you like to do?

  1. Go to room settings (in the left panel, ⋯ -> Settings)
  2. Under Room Addresses -> Published Addresses, add and address that looks like "#someaddress"
  3. Add
  4. Get pop-up with "Error updating main address"
  5. Close dialog
  6. See bad alias shown in the list
  7. Under "main address" dropdown, see the bad alias listed
  8. Select the bad alias under "main address" to get another error dialog

Outcome

What did you expect?

Modal window with proper description of the error appears, that clearly describes what the error is.

What happened instead?

A very generic error window appears, that doesn't tell you what kind of an error happened or how to fix it.
See attached screenshot:
CleanShot 2021-11-12 at 15 23 15

TODO

Requires a list of all the errors returned by state/m.room.canonical_alias/ endpoint and a way to translate them.

@SimonBrandner
Copy link
Contributor

Related matrix-org/matrix-react-sdk#6180

@Palid
Copy link
Contributor Author

Palid commented Nov 13, 2021

@SimonBrandner that change looks like something we wanna get ASAP 😄

@aaronraimist
Copy link
Collaborator

Feel free to pick it up. Current status is matrix-org/matrix-react-sdk#6180 (comment)

@SimonBrandner SimonBrandner added A-Aliases A-Room-Settings O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 14, 2021
@SimonBrandner SimonBrandner added the Help Wanted Extra attention is needed label Nov 14, 2021
@Palid
Copy link
Contributor Author

Palid commented Nov 17, 2021

I'll probably pick it up later and interate on top of it, as I have an issue with the the aliases already.

@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Aliases A-Room-Settings Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants