Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing keys without input focused adds weird focus ring to message instead of typing #19852

Closed
lilyball opened this issue Nov 22, 2021 · 3 comments
Labels
A-Composer A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@lilyball
Copy link

Steps to reproduce

  1. I'm in a room. I can see the sidebar and the room chat.
  2. I click on a message to remove focus from the input.
  3. I press any letter on my keyboard

Outcome

What did you expect?

I expected it to type that letter into the input, like both Slack and Discord do.

What happened instead?

It put a focus ring around the message. Other than that, it did nothing at all with the key I pressed. Nothing I press at this point seems to actually do anything with the message. I also don't see any way with just the keyboard to move focus to the input field beyond pressing Tab enough times to get focus all the way there (past every other focusable element on the page).

Clicking on the page removes the focus ring, but pressing a key again just focuses the new message I clicked.

Pressing Space seems to both add the focus ring and scroll down by a page.

Operating system

macOS

Application version

Version 1.9.5

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes

@lilyball
Copy link
Author

I've tried sending logs three times now. Do the logs not actually get attached to the GitHub issue? If so, this is non-obvious (I'd at least have expected some indication added to the issue to signal that logs were submitted).

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2021

They do but given that the logs are private only people with access to them can see them.

image

@SimonBrandner SimonBrandner added A-Composer A-Shortcuts Keyboard shortcuts S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Regression labels Nov 23, 2021
@robintown
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#7167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

4 participants