Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appropriate limit to image width/size #19869

Open
HarHarLinks opened this issue Nov 23, 2021 · 2 comments
Open

Appropriate limit to image width/size #19869

HarHarLinks opened this issue Nov 23, 2021 · 2 comments
Labels
A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Nov 23, 2021

Your use case

What would you like to do?

Images can have many aspect ratios. Recently this setting was added to element (matrix-org/matrix-react-sdk#7017):
image
I like that feature very much for most use cases, for example: often a smartphone screenshot is shared with a 9:16 or similar ratio at resolutions of 1080x1920. That is huge and fills out the whole screen.

On the other hand, sometimes I share screenshots like the following:
image
image

I would like there to be a threshold of aspect ratio where element displays the thumbnail still at max width (as it used to), but as the aspect ratio gets closer to square, limit it (by height, e.g. as high as a collapsed code block?).

Why would you like to do it?

There is no use in limiting pictures like these to 1/3 of the timeline width (on 1080p, with right panel open), actually it limits the usefulness as I can barely recognize what the thumbnail is of.

How would you like to achieve it?

I think it is more complicated than simply limiting height. In the end an image should take up a maximum amount of display area. There is a threshold somewhere in there where an image starts to feel overwhelmingly large.

Have you considered any alternatives?

No response

Additional context

#19788

@HarHarLinks
Copy link
Contributor Author

image

This case is so ridiculous, I thought it was a <hline>/--- for a second.

@SimonBrandner SimonBrandner added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Feb 8, 2022
@HarHarLinks
Copy link
Contributor Author

image

the timestamp (see on the left) can get overlapped: an element should be fixed to have minimum height of 1em ("one line of text") or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design
Projects
None yet
Development

No branches or pull requests

3 participants