Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red shield in forwarding preview #19913

Closed
HarHarLinks opened this issue Nov 26, 2021 · 10 comments · Fixed by matrix-org/matrix-react-sdk#7447
Closed

Red shield in forwarding preview #19913

HarHarLinks opened this issue Nov 26, 2021 · 10 comments · Fixed by matrix-org/matrix-react-sdk#7447
Assignees
Labels
A-E2EE good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. forward a message (from a fully verified e2ee room?)

Outcome

What did you expect?

no red shields

What happened instead?

red shield in the preview

Operating system

arch

Application version

Element Nightly version: 2021112501 Olm version: 3.2.3

How did you install the app?

aur

Homeserver

No response

Will you send logs?

No

@SimonBrandner SimonBrandner added A-E2EE good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 26, 2021
@ankur12-1610
Copy link
Contributor

I'll work on it!

@ankur12-1610
Copy link
Contributor

@HarHarLinks I'm unable to reproduce the issue:sweat_smile:.
Kindly elaborate more properly.

@SimonBrandner
Copy link
Contributor

@HarHarLinks I'm unable to reproduce the issuesweat_smile. Kindly elaborate more properly.

Try forwarding a message from an encrypted room, it should happen then

@HarHarLinks
Copy link
Contributor Author

yes, the required condition seems to be that the room is encrypted.
image

@ankur12-1610
Copy link
Contributor

yes, the required condition seems to be that the room is encrypted. image

Ah! got it:+1:

@ankur12-1610
Copy link
Contributor

I found some files related to the e2eIcon and found this file the most relatable one, I tried using visibility: hidden but it didn't work. Need some help 😅

@SimonBrandner
Copy link
Contributor

I found some files related to the e2eIcon and found this file the most relatable one, I tried using visibility: hidden but it didn't work. Need some help sweat_smile

The easiest solution might be finding the CSS class of the icon and then in the SCSS file of the forwarding dialog set its display property to none

@ankur12-1610
Copy link
Contributor

I found some files related to the e2eIcon and found this file the most relatable one, I tried using visibility: hidden but it didn't work. Need some help sweat_smile

The easiest solution might be finding the CSS class of the icon and then in the SCSS file of the forwarding dialog set its display property to none

I did the same, but the css class of the icon already has its display property to none. Can you please visit the file attached in the above comment:')

@SimonBrandner
Copy link
Contributor

I found some files related to the e2eIcon and found this file the most relatable one, I tried using visibility: hidden but it didn't work. Need some help sweat_smile

The easiest solution might be finding the CSS class of the icon and then in the SCSS file of the forwarding dialog set its display property to none

I did the same, but the css class of the icon already has its display property to none. Can you please visit the file attached in the above comment:')

Argh, perhaps try display: none !important;

@ankur12-1610
Copy link
Contributor

I found some files related to the e2eIcon and found this file the most relatable one, I tried using visibility: hidden but it didn't work. Need some help sweat_smile

The easiest solution might be finding the CSS class of the icon and then in the SCSS file of the forwarding dialog set its display property to none

I did the same, but the css class of the icon already has its display property to none. Can you please visit the file attached in the above comment:')

Argh, perhaps try display: none !important;

I got the CSS class, turns out it was .mx_EventTile_e2eIcon_warning. So I set it's display property to none.

I've raised a PR(#7447), kindly review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants