Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps on images are not readable #20402

Closed
robintown opened this issue Jan 4, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7521
Closed

Timestamps on images are not readable #20402

robintown opened this issue Jan 4, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7521
Assignees
@t3chguy @amshakal
Labels
A11y A-Media A-Message-Bubbles A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Labs

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Enable message bubble layout
  2. Send or receive any busy, grey-ish image
  3. Hover over the image

Outcome

Screenshot 2022-01-04 at 15-05-57 Element general

What did you expect?

To be able to read the timestamp.

What happened instead?

The timestamp is unreadable against the background of the image. Making the timestamp lighter and putting it against a dark backdrop, as in matrix-org/matrix-react-sdk#6511, could aid readability.

Operating system

NixOS unstable

Browser information

Firefox 95.0.2

URL for webapp

develop.element.io

Application version

Element version: 211f480-react-00feb248778a-js-f30be8787934 Olm version: 3.2.8

Homeserver

townsendandsmith.ml

Will you send logs?

No
@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline A-Media A11y A-Message-Bubbles O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 4, 2022
@github-actions github-actions bot added the Z-Labs label Jan 4, 2022
@amshakal
Copy link

I have added a gradient to the bottom of the image to take care of this issue. It should work for light and dark modes both.
Screenshot 2022-01-12 at 4 28 54 pm

Link to Figma: https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=1691%3A38484

@t3chguy t3chguy self-assigned this Jan 12, 2022
@t3chguy t3chguy mentioned this issue Jan 12, 2022
Merged
@robintown robintown mentioned this issue Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

@amshakal amshakal

Labels
A11y A-Media A-Message-Bubbles A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linear gradient to images in bubble layout matrix-org/matrix-react-sdk
3 participants
@t3chguy @robintown @amshakal