Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Can't load this message" for a notice event #21193

Closed
andybalaam opened this issue Feb 24, 2022 · 5 comments
Closed

"Can't load this message" for a notice event #21193

andybalaam opened this issue Feb 24, 2022 · 5 comments
Labels
A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Won't-Fix

Comments

@andybalaam
Copy link
Member

andybalaam commented Feb 24, 2022

Steps to reproduce

  1. Enter a room and see a message whose source is this:
{
  "content": {
    "body": "> <undefined> \n\n**J‎ordan C‎onnor**: +1",
    "format": "org.matrix.custom.html",
    "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!oqOIeEMggmJDUIJWHb:matrix.org/undefined\">In reply to</a> <a href=\"https://matrix.to/#/undefined\">undefined</a><br /></blockquote></mx-reply><strong>J‎ordan C‎onnor</strong>: +1",
    "m.relates_to": {
      "m.in_reply_to": {}
    },
    "msgtype": "m.notice",
    "uk.half-shot.matrix-hookshot.figma.comment_id": "156063232"
  },
  "origin_server_ts": 1645547287287,
  "sender": "@figmabot:half-shot.uk",
  "type": "m.room.message",
  "unsigned": {},
  "event_id": "$08wE7gxQEvTTILx5OcrRw-l5pozABBO2tBBOCNvSf3I",
  "room_id": "!oqOIeEMggmJDUIJWHb:matrix.org"
}

Outcome

What did you expect?

The message to render or be invisible

What happened instead?

An error was displayed: "Can't load this message (m.room.message)"

Operating system

Ubuntu 21.10

Browser information

Firefox 96.0 (64-bit)

URL for webapp

https://develop.element.io

Application version

Element version: 3810b7e-react-f4cd71fd47c7-js-2ec5acb55d35
Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

Yes

@andybalaam
Copy link
Member Author

I get the same message in app.element.io - I'm wondering whether this is a bridge issue.

@germain-gg
Copy link
Contributor

Looks like the most likely suspect

2022-02-24T09:29:00.999Z E Unknown entity type in permalink
parsePermalink@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:138051:13
parsePermalink@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:25099:66
pillifyLinks@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:190489:106
pillifyLinks@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:190566:19
pillifyLinks@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:190566:19
applyFormatting@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:214733:81
componentDidMount@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:214723:12
Yi@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99247:411
dk@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99287:160
exports.unstable_runWithPriority@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99392:343
gg@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99150:325
Uj@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99280:281
Lj@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99271:373
jg/<@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99151:115
exports.unstable_runWithPriority@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99392:343
gg@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99150:325
jg@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99151:63
ig@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99150:428
Jg@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99265:203
enqueueSetState@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99161:213
C.prototype.setState@https://develop.element.io/bundles/92a494e9394a6d8a7a39/vendors~init.js:99344:369
onLoaded@https://develop.element.io/bundles/92a494e9394a6d8a7a39/init.js:63110:12

@germain-gg germain-gg added A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression labels Feb 24, 2022
@turt2live
Copy link
Member

I'm not sure we should do anything about this - the event is very clearly invalid, likely caused by a bug in the bridge itself.

This is the exact sort of behaviour I'd expect for this kind of event.

@t3chguy
Copy link
Member

t3chguy commented Feb 25, 2022

@turt2live one of the rageshakes is a full on soft crash, so there's definitely room for improvement in the search side of this.

@t3chguy t3chguy reopened this Feb 25, 2022
@turt2live
Copy link
Member

I'm going to open the search issue as a new issue, as it's not the same cause as the notice event here.

The notice event is invalid. The search result was valid.

#21216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Won't-Fix
Projects
None yet
Development

No branches or pull requests

5 participants