Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spotlight should be navigatable by page up/down keys #21256

Open
weeman1337 opened this issue Mar 1, 2022 · 10 comments
Open

New spotlight should be navigatable by page up/down keys #21256

weeman1337 opened this issue Mar 1, 2022 · 10 comments
Labels
A-New-Search-Experience The new search dialog available in Labs A-Shortcuts Keyboard shortcuts good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Mar 1, 2022

Your use case

What would you like to do?

An a user I want to be able to navigate through the new spotlight search results by using the page up/down keys
so that I am able to reach my search results quickly.

Why would you like to do it?

How would you like to achieve it?

Page up/down keys should scroll the search result list by ? half/full pages.

Have you considered any alternatives?

Holding down the up/down arrow keys. But this is slow.

Additional context

No response

@aaronraimist aaronraimist added A-Timeline-Search T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter and removed T-Enhancement labels Mar 1, 2022
@aaronraimist
Copy link
Collaborator

Are you talking about searching the contents of a room? You should already be able to scroll with page up and down. If it doesn't work for you then we probably need information about what browser you are using.

If you mean arrow up and arrow down for individual results that would be #16788

@weeman1337
Copy link
Contributor Author

Ah no - it is about the spotlight search. Wanted to make that clear by using a label. But I was unable to set it.

@weeman1337 weeman1337 changed the title Search should be navigatable by page up/down keys New spotlight should be navigatable by page up/down keys Mar 1, 2022
@aaronraimist aaronraimist added A-New-Search-Experience The new search dialog available in Labs T-Enhancement Z-Labs and removed A-Timeline-Search X-Needs-Info This issue is blocked awaiting information from the reporter T-Defect labels Mar 1, 2022
@SimonBrandner SimonBrandner added A-Shortcuts Keyboard shortcuts O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 1, 2022
@germain-gg germain-gg added the good first issue Good for newcomers label May 19, 2022
@kittykat kittykat added the Help Wanted Extra attention is needed label Jul 15, 2022
@psavan1655
Copy link

I would like to work on it. First want to clear some doubts here.
We are talking about the search bar, where we search for the rooms and all. Right?

Suggestion: Rather than doing Full / Half page scroll, we can do a fix number, Let's say scroll 10 search results on Page Up/Down. @weeman1337

@weeman1337
Copy link
Contributor Author

We are talking about the search bar, where we search for the rooms and all. Right?

Nope. It is the new search if you click into the search field on the top left:

image

@NSV1991
Copy link

NSV1991 commented Apr 5, 2023

If this change is done, won't it override the current functionality implemented in #16788 ?

@t3chguy
Copy link
Member

t3chguy commented Apr 5, 2023

@NSV1991 that issue is about timeline search, not spotlight search, also that is an unclosed issue, why would it be implementing functionality?

@NSV1991
Copy link

NSV1991 commented Apr 6, 2023

@t3chguy Pardon me if my question is confusing. I am trying to understand what are we trying to achieve here.
Below is my implementation locally (not committed yet). Please check the below video and guide me if I am in the right direction

Currently working in spotlight
Spotlight current working scroll.webm

Updated new scroll in spotlight using keyboard
NewUpdatedScroll.webm

@t3chguy
Copy link
Member

t3chguy commented Apr 6, 2023

@NSV1991 this is asking for the Page Up and Page Down keys to work in the spotlight, you seem to have just changed how the scrolling for up/down arrow keys works.

@NSV1991
Copy link

NSV1991 commented Apr 7, 2023

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2023

@NSV1991 almost, it seems to only be moving about 60% of a page rather than a page though

@t3chguy t3chguy removed the Z-Labs label Jul 17, 2023
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Search-Experience The new search dialog available in Labs A-Shortcuts Keyboard shortcuts good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants