Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix that element won't ask another element user for resending/redoing encryption if we're both connected #23512

Closed
ell1e opened this issue Oct 17, 2022 · 3 comments
Assignees
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-UISI Unable to decrypt errors

Comments

@ell1e
Copy link

ell1e commented Oct 17, 2022

Steps to reproduce

  1. We're both chatting in an encrypted chat. Suddenly I'm seeing this:

Screenshot from 2022-10-18 00-46-17

  1. We continue talking, the next messages work again, but here comes the catch:
  2. As we talk, evidently have a working connection with working encryption again, the above error messages do not recover with the proper message contents

Outcome

What did you expect?

If a secure encryption is established again with a sender client that has just minutes ago sent me messages from that same device and something about the keys failed, the protocol absolutely should fetch those again.

What happened instead?

Doesn't work, I just stare at errors and have to clumsily ask what was even said, and/or feel embarrassed again for making other people even use Matrix. And I even use Labs and hydrated backup device enabled, I don't know what failed with that with us both not even switching devices - and I think that's less relevant than the question why it doesn't recover. These failures would be so much less disruptive and sad if the clients just talked this out.

Operating system

Fedora 36

Application version

Element version: 1.11.8 Olm version: 3.2.12

How did you install the app?

via flathub flatpak

Homeserver

matrix.org, room is also on matrix.org, other user also uses matrix.org. room has more than us two as users though, some of those from somewhere else

Will you send logs?

Yes

@ell1e ell1e added the T-Defect label Oct 17, 2022
@uhoreg uhoreg added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE Z-UISI Unable to decrypt errors O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 19, 2022
@uhoreg
Copy link
Member

uhoreg commented Oct 19, 2022

Just to confirm, was the other user using the same device when sending both the undecryptable messages and the succesfully-decrypted messages?

@ell1e
Copy link
Author

ell1e commented Oct 19, 2022

If I understood their description right then yes. On my end no device switch either, it also was just minutes apart. Two messages mid conversation basically just failed out of the blue, it worked before and it worked after, but the two messages just never recovered.

@richvdh richvdh self-assigned this Nov 18, 2022
@richvdh
Copy link
Member

richvdh commented Nov 18, 2022

Hi, thanks for the report.

I've studied the logs and it looks like the original problem was due to #23792. In this case it looks to have been triggered by the sender using element in two tabs at once (not that that is an unreasonable thing to do!)

duplicate of #23792.

@richvdh richvdh closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-UISI Unable to decrypt errors
Projects
None yet
Development

No branches or pull requests

3 participants