Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipts in threads overlap interactive elements #23576

Open
bmarty opened this issue Oct 24, 2022 · 3 comments
Open

Read receipts in threads overlap interactive elements #23576

bmarty opened this issue Oct 24, 2022 · 3 comments
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@bmarty
Copy link
Member

bmarty commented Oct 24, 2022

Steps to reproduce

  1. Open a thread
  2. Edit a message

Outcome

What did you expect?

Nice UI

What happened instead?

image

Operating system

MacOS

Application version

Element version: b924594-react-d4f1c573adf1-js-a12e6185f9cc Olm version: 3.2.12

How did you install the app?

develop.element.io

Homeserver

Any I guess

Will you send logs?

No

@kerryarchibald kerryarchibald added A-Threads S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 24, 2022
@kerryarchibald
Copy link
Contributor

Related to #23569?

@germain-gg germain-gg self-assigned this Oct 24, 2022
@germain-gg germain-gg changed the title [Threads] Read receipt and message edition: issue in layout Read receipt and message edition: issue in layout Oct 24, 2022
@richvdh richvdh changed the title Read receipt and message edition: issue in layout Read receipt and message editing: issue in layout Nov 18, 2022
@germain-gg germain-gg removed their assignment Jan 13, 2023
@luixxiul
Copy link

luixxiul commented Mar 6, 2023

This is reproduced on modern layout, not bubble message one.

Fixed locally, which should be pushed as PR once matrix-org/matrix-react-sdk#9016 is merged.

It turned out that displaying the read receipt group in its full width needed a lot of space on the thread panel, which creates a similar problem like #21890.

I think we want to avoid this layout, based on the main timeline.

Screenshot from 2023-03-09 03-48-10

I guess limiting the number of avatars in read receipt might need to be decreased, otherwise it would not be possible for the read receipt to avoid overlapping the save button.

Hiding it while the post is edited can be an option too.

Input on the design is appreciated.

@t3chguy t3chguy changed the title Read receipt and message editing: issue in layout Read receipts in threads overlap interactive elements May 12, 2023
@t3chguy
Copy link
Member

t3chguy commented May 12, 2023

Also applies to video controls as per #25350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants