Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop out jitsi call does not work when openidtoken-jwt is enabled #23700

Closed
krombel opened this issue Nov 4, 2022 · 5 comments
Closed

Pop out jitsi call does not work when openidtoken-jwt is enabled #23700

krombel opened this issue Nov 4, 2022 · 5 comments
Labels
A-Jitsi O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: VoIP Element's VoIP team

Comments

@krombel
Copy link
Contributor

krombel commented Nov 4, 2022

Steps to reproduce

  1. enable openidtoken-jwt authentication for jitsi
  2. add jitsi widget to room
  3. click "Pop out"
  4. "Joining" Window (jitsi.html) opens

Outcome

What did you expect?

I can join conference

What happened instead?

When clicking on "Join Conference" it says "Failed to load Jitsi widget"

Operating system

Browser information

URL for webapp

No response

Application version

1.11.13

Homeserver

synapse 1.70.0

Will you send logs?

No
@t3chguy
Copy link
Member

t3chguy commented Nov 4, 2022

This is a known issue, though I thought we disabled the pop-out button when auth was used

@krombel
Copy link
Contributor Author

krombel commented Nov 4, 2022

It is not disabled

@t3chguy t3chguy added A-Jitsi Team: VoIP Element's VoIP team S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 4, 2022
@krombel
Copy link
Contributor Author

krombel commented Nov 4, 2022

Wouldn't it be possible to append an openId token to that popout url (leaving the other arguments as is)
I would try a PR for that if wanted

@t3chguy
Copy link
Member

t3chguy commented Nov 4, 2022

It'd be possible but it is unlikely to be desirable, a link is easily wrongly shared, breaking the security model

@dhenneke
Copy link
Contributor

dhenneke commented Sep 8, 2023

I think this issue can be closed since it was solved by #24294. The solution there was to just hide the button since it can't work in this situation.

@t3chguy t3chguy closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Jitsi O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: VoIP Element's VoIP team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhenneke @t3chguy @krombel