Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent starting a broadcast if connection is unavailable #24139

Closed
weeman1337 opened this issue Jan 3, 2023 · 1 comment
Closed

Prevent starting a broadcast if connection is unavailable #24139

weeman1337 opened this issue Jan 3, 2023 · 1 comment
Labels
A-Broadcast Broadcast-style voice messages O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Labs

Comments

@weeman1337
Copy link
Contributor

Your use case

What would you like to do?

It should not be possible to start a broadcast if the connection is unavailable.

Why would you like to do it?

It doesn't make sense.

How would you like to achieve it?

Don't start the broadcast. Show a dialog instead:

  • Title: „Connection error“
  • Message: „Unfortunately we're unable to start a recording right now. Please try again later.“
  • Button: Only „OK“

Have you considered any alternatives?

No response

Additional context

No response
@weeman1337 weeman1337 added T-Enhancement Z-Labs A-Broadcast Broadcast-style voice messages labels Jan 3, 2023
@SimonBrandner SimonBrandner added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Jan 3, 2023
@weeman1337 weeman1337 mentioned this issue Jan 4, 2023
Merged
3 tasks
@weeman1337
Copy link
Contributor Author

closed by matrix-org/matrix-react-sdk#9857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Broadcast Broadcast-style voice messages O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weeman1337 @SimonBrandner