Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line created with shift-enter in RTE code block is not displayed until typing on that line #24331

Closed
BurnyBoi opened this issue Jan 25, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#10008
Labels
A-Composer A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@BurnyBoi
Copy link

BurnyBoi commented Jan 25, 2023

Steps to reproduce

(With the Rich Text Editor lab enabled)

  1. Click "Code Block" on a blank compose box to start a new block
  2. Type the first line of code
  3. Press Shift-Enter to start a new line. Nothing visibly happens
  4. Type the second line of code. Observe that now the new line is visibly created and the second line is typed in the correct place.

Outcome

What did you expect?

When pressing Shift-Enter in the code block, the cursor should move down to a new line right away

What happened instead?

New line is not visible until you actually start typing on that line.

image

(Typed out first line, then pressed Shift-Enter. There is no indication I am now on the second line. Cursor is still incorrectly shown as being on the right of the first line and the code block has not increased in size)

image

(As soon as I type the "s" in "second line of code", the code block increases in height, the new line is visible, the cursor jumps down to it and types there.)

Operating system

Arch Linux

Browser information

Firefox 106

URL for webapp

develop.element.io

Application version

Element version: bd26775-react-222f8a919dd9-js-cb613457801b Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

No

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Labs and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants