You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This area is highly sensitive design wise, so per other PRs I'm intending to take a look before it lands.
It's not ideal that we currently don't have screenshot tests for voice messages.
We have very strict tolerances on the padding/margins for the voice message components though - I'm going to look into adding screenshot tests for this area.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered:
luixxiul
changed the title
Create a screenshot test for Player of audio file and voice message
Create a screenshot test for voice message player
Jun 20, 2023
Steps to reproduce
Outcome
What did you expect?
There should be a screenshot test for it.
What happened instead?
There is not a test, and a manual review is required.
The lack of a screenshot test has really discouraged us to fix visual bugs of audio player and voice message player.
See: #22541 (comment), matrix-org/matrix-react-sdk#8861 (comment), matrix-org/matrix-react-sdk#8815 (comment), and matrix-org/matrix-react-sdk#8861 (comment)
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: