Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a default user pill when the matrixId is unknown #24782

Closed
giomfo opened this issue Mar 9, 2023 · 7 comments
Closed

Display a default user pill when the matrixId is unknown #24782

giomfo opened this issue Mar 9, 2023 · 7 comments

Comments

@giomfo
Copy link
Member

giomfo commented Mar 9, 2023

Steps to reproduce

Send in a room the following permalink : "https://matrix.to/#/@sddfshfjkashfk:matrix.org" with an unknown matrixId

Outcome

What did you expect?

a pill with the user's name and profile picture if any. Like this: Screenshot 2023-02-21 at 18 09 52
If the matrix id is unknown, the pill should show the default user icon and "User" (the mxId is visible in overlay) : image

What happened instead?

A pill with the mxId is displayed:
image

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@MadLittleMods
Copy link
Contributor

If the matrix id is unknown, the pill should show the default user icon and "User" (the mxId is visible in overlay) :

@giomfo Why is this expected for you? I would much rather prefer to see the MXID pill for someone we can't pull the display name/avatar information for.

It will get hard to disambiguate when there are multiple unknown "User" showing up everywhere.

@t3chguy
Copy link
Member

t3chguy commented Mar 16, 2023

It'd also be impossible to disambiguate from someone in the room called User with that specific avatar

@daniellekirkwood
Copy link
Contributor

We had push back on showing the avatar and display name/ mxid for users that you're not familiar with because what if they're abusive... If someone references a user that's "@explitive:rude.com" the solution you're suggesting would reveal that to all users in the room. Our solution hides it and shows "User" whilst giving folks the ability to click/hover and see the MXID if they choose to.

The reason we're not just rendering the MXID username and avatar is to cover the abuse cases - I want to make sure we're not leaving that same method open with your suggestion.

@MadLittleMods
Copy link
Contributor

We had push back on showing the avatar and display name/ mxid for users that you're not familiar with

How is a user determined to be familiar? Is this just whether they're in the room or not? Ban list for a room?

The community can always ban/block/kick the user if they're using a name that isn't suitable for the community. It might make sense to do some of this obfuscation if someone wants to block a particular user. Even in a moderation setting, I would want to see the offensive language to know who was banned/blocked. An avatar may be more problematic.

And if we're thinking about the good no-abuse case, it would suck not to show the avatar/display name for a good person you're genuinely referencing. Imagine introducing your coworker as @eric:element.io instead of a nice pill. It just looks like something is not working in Element if we don't display a nice pill.

@weeman1337
Copy link
Contributor

@giomfo can you confirm that we now decided to still display the MXID instead of »User« ?

@daniellekirkwood
Copy link
Contributor

@weeman1337 Yes, we're going to stick with the MXID

I think that means we can close this issue

@MadLittleMods
Copy link
Contributor

The discussion being referenced above happened out of band in an internal room and a meeting which I don't have context for.

The conclusion from the discussion was:

Let's go for the mxId with default user icon

Which seems to be how we already handle things today.

Closing the issue ⏩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants