You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might be an upstream issue, but it seems that Percy tests do not capture movement of collapse link button on GELS (generic event list summary), introduced with matrix-org/matrix-react-sdk#10211.
Here are the Percy results which seem to have the issue (please check it by toggling original and new):
The horizontal row where collapse link button exists should be highlighted, as its movement (by matrix-org/matrix-react-sdk#10211) is exactly what caused the snapshot changes.
What happened instead?
Percy did not highlight the row. It highlights other parts instead, which I think is quite confusing to those who did not work on the change.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered:
Steps to reproduce
This might be an upstream issue, but it seems that Percy tests do not capture movement of
collapse
link button on GELS (generic event list summary), introduced with matrix-org/matrix-react-sdk#10211.Here are the Percy results which seem to have the issue (please check it by toggling
original
andnew
):Those snapshots are built on this PR: matrix-org/matrix-react-sdk#10189
Outcome
What did you expect?
The horizontal row where
collapse
link button exists should be highlighted, as its movement (by matrix-org/matrix-react-sdk#10211) is exactly what caused the snapshot changes.What happened instead?
Percy did not highlight the row. It highlights other parts instead, which I think is quite confusing to those who did not work on the change.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: