Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy tests do not capture movement of collapse link button on GELS #24949

Closed
luixxiul opened this issue Mar 24, 2023 · 1 comment
Closed

Percy tests do not capture movement of collapse link button on GELS #24949

luixxiul opened this issue Mar 24, 2023 · 1 comment

Comments

@luixxiul
Copy link

luixxiul commented Mar 24, 2023

Steps to reproduce

This might be an upstream issue, but it seems that Percy tests do not capture movement of collapse link button on GELS (generic event list summary), introduced with matrix-org/matrix-react-sdk#10211.

Here are the Percy results which seem to have the issue (please check it by toggling original and new):

Those snapshots are built on this PR: matrix-org/matrix-react-sdk#10189

Outcome

What did you expect?

The horizontal row where collapse link button exists should be highlighted, as its movement (by matrix-org/matrix-react-sdk#10211) is exactly what caused the snapshot changes.

What happened instead?

Percy did not highlight the row. It highlights other parts instead, which I think is quite confusing to those who did not work on the change.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@andybalaam
Copy link
Contributor

I agree the highlighting is unfortunate, but this is definitely a Percy issue, not Element Web, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants