Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <SettingsTab> on every settings tab #25227

Closed
luixxiul opened this issue Apr 27, 2023 · 1 comment
Closed

Use <SettingsTab> on every settings tab #25227

luixxiul opened this issue Apr 27, 2023 · 1 comment

Comments

@luixxiul
Copy link

Your use case

What would you like to do?

Import <SettingsTab> on every settings tab and use it

Why would you like to do it?

Because using it on every settings tab improves consistency. Note it is is currently only used on VoipRoomSettingsTab.tsx and SessionManagerTab.tsx, and I assume nobody is actively working on that task.

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

This issue should be closed if <SettingsTab> has been deprecated.

@luixxiul
Copy link
Author

luixxiul commented May 1, 2023

@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants