Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long room address overflows general room setting tab #25614

Closed
luixxiul opened this issue Jun 16, 2023 · 8 comments
Closed

Long room address overflows general room setting tab #25614

luixxiul opened this issue Jun 16, 2023 · 8 comments
Labels
A-Room-Settings good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Create a room
  2. Set the room address to something like Loremipsumdolorsitametconsecteturadipisicingelitseddoeiusmodtemporincididuntutlaboreetdoloremagnaaliqdoloremagnaaliqdoloremagnaaliq:matrix.org

Outcome

What did you expect?

What happened instead?

0

Operating system

Debian

Browser information

Firefox

URL for webapp

app.element.io

Application version

1.11.33

Homeserver

No response

Will you send logs?

No

@luixxiul
Copy link
Author

Create a E2E test to confirm the fix along with the fix itself.

@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels Jun 19, 2023
@github-actions github-actions bot added the Help Wanted Extra attention is needed label Jun 19, 2023
@Rohit-Singh-Rawat
Copy link

Can u assign me this issue .

@t3chguy
Copy link
Member

t3chguy commented Jul 3, 2023

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@NEUDitao
Copy link

So would the fix be moreso "prevent this from happening," or "allow useres to input these inputs, but let's make it so the text box actually shows the end?"

I don't know if there's a designer behind the app/a design philosophy, so I don't want to step on any toes here if I put up a draft

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2023

@NEUDitao you can't prevent this from happening given other clients may cause it and it may already be the set room address for rooms. Its just about handling it more sanely, ellipsis etc

@amanopia
Copy link

amanopia commented Aug 5, 2023

Hey! I was trying to reproduce this issue on my system by setting up the application. But I am having trouble with starting the application and instead getting this error.

image

And when I am trying to locate this file, nothing is turning up.
I have installed all the dependencies for matrix-js-sdk and matrix-react-sdk as well as for the main project. But when I am checking in the github desktop application, I can see that the version of dependencies has been updated. Could that be a problem? Also, I accidentally ran npm install the first time while I was setting up the application instead of using yarn install. Could that be a potential cause? Would cloning the whole thing again and redoing the steps help? Also I would really appreciate it if someone can explain why do we need to copy the config.sample.json file to config.json? I am suspecting might be so that we can customize it according to our needs.
I am new to open source, can someone help me with the issue? Any help would be appreciated. Thanks!

@t3chguy
Copy link
Member

t3chguy commented Aug 7, 2023

@germain-gg the above developer issue is one you said you were looking into

@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
@BhargavaCreates
Copy link

shouldn't this issue be now closed? since we have gotten the PR merged.

@t3chguy t3chguy closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Settings good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

8 participants